Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bytecode decoder to tvm-spec #39

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

hacker-volodya
Copy link
Contributor

For a long time there was a simple tvm-spec-example disassembler, which is able to decode all TVM instructions correctly, even newest ones (using tvm-spec). However, tvm-spec-example is just an example and it lacks some flexibility, so lets combine its instruction decoder with ton-opcode.

Shvandre
Shvandre previously approved these changes Jan 30, 2025
Copy link
Contributor

@Shvandre Shvandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a miracle to me

@novusnota
Copy link
Member

novusnota commented Jan 30, 2025

@hacker-volodya A massive contribution!

Unfortunately, CI fails and there is no test coverage to check whether the decompiler is still correct or at least more correct than before. To merge this, CI needs to be green :)

Besides, the package manager of this project is yarn, that's why there was a yarn.lock there — please remove the package-lock.json which came with npm

@Shvandre Shvandre self-requested a review January 31, 2025 15:35
@i582
Copy link
Contributor

i582 commented Feb 16, 2025

Hey, thanks for your contribution, this is a really important addition! We will merge it as is and then fix possible issues ourselves! Thank you very much!

i582
i582 previously approved these changes Feb 16, 2025
@anton-trunov anton-trunov merged commit d2db1c3 into tact-lang:main Feb 16, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants