-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate bytecode decoder to tvm-spec #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a miracle to me
@hacker-volodya A massive contribution! Unfortunately, CI fails and there is no test coverage to check whether the decompiler is still correct or at least more correct than before. To merge this, CI needs to be green :) Besides, the package manager of this project is |
Hey, thanks for your contribution, this is a really important addition! We will merge it as is and then fix possible issues ourselves! Thank you very much! |
For a long time there was a simple tvm-spec-example disassembler, which is able to decode all TVM instructions correctly, even newest ones (using tvm-spec). However, tvm-spec-example is just an example and it lacks some flexibility, so lets combine its instruction decoder with ton-opcode.