fix(cdk): tuiCreateToken with no arguments should not create token with default undefined-value#10682
fix(cdk): tuiCreateToken with no arguments should not create token with default undefined-value#10682nsbarsukov merged 1 commit intomainfrom
tuiCreateToken with no arguments should not create token with default undefined-value#10682Conversation
…with default `undefined`-value
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
View your CI Pipeline Execution ↗ for commit 716539a.
☁️ Nx Cloud last updated this comment at |
|
Visit the preview URL for this PR (updated for commit 716539a): https://taiga-previews-demo--pr10682-create-token-fix-demo-9vvvf7ow.web.app (expires Sat, 29 Mar 2025 09:01:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10682 +/- ##
========================================
Coverage 65.50% 65.50%
========================================
Files 1267 1267
Lines 16697 16698 +1
Branches 2475 2382 -93
========================================
+ Hits 10937 10938 +1
- Misses 5449 5560 +111
+ Partials 311 200 -111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BundleMonUnchanged files (5)
Total files change +9B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Playwright test results
Details
Failed testschromium › tests/core/dropdown/dropdown.pw.spec.ts › Dropdown › Hosted dropdown initial width Skipped testschromium › tests/addon-mobile/mobile-dropdown/mobile-dropdown-with-textfield.pw.spec.ts › DropdownMobile for textfields › with select |
https://stackblitz.com/edit/option-content-with-skip-self
TUI_OPTION_CONTENTis projected content viapolymorpheusOutlet(legacy approach) /createComponent(modern approach). Both approaches attach parent injector to this projected component.Previous behavior:
inject(TUI_OPTION_CONTENT, {skipSelf: true))looks inside local injectors and get defaultundefined(from token factory). Stop exploring DI hierarchy (do not explore "parent" injectors).New behavior:
inject(TUI_OPTION_CONTENT, {skipSelf: true))is not found inside "local" injectors - we reach "local"NullInjector=> Got to "parent" inejctors.