Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): forgot add peer dependency #9356

Closed
wants to merge 2 commits into from

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Oct 5, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 5, 2024

Visit the preview URL for this PR (updated for commit fc4a9ee):

https://taiga-previews--pr9356-splincode-fix-peer-a-du5qmwew.web.app

(expires Sun, 06 Oct 2024 19:12:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 5, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
293.7KB +10%
demo/browser/vendor.(hash).js
247.36KB +10%
demo/browser/runtime.(hash).js
42.98KB +10%
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.11MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode linked an issue Oct 5, 2024 that may be closed by this pull request
@waterplea
Copy link
Collaborator

I don't think this is how we should fix it, I think we should get rid of the dependency since it's a legacy package. I'll take a look on Monday, should be possible one way or another.

@splincode splincode closed this Oct 6, 2024
@splincode splincode deleted the splincode/fix-peer-addon-table branch October 6, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - AbstractTuiControl is not defined
3 participants