feat: update comments

taikoxyz · Jan 22, 2025 · 7d6fc87 · 7d6fc87
1 parent 8275a72
commit 7d6fc87
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/taiko-client/proposer/transaction_builder/blob.go b/packages/taiko-client/proposer/transaction_builder/blob.go
@@ -8,6 +8,7 @@ import (
 
 	"github.com/ethereum-optimism/optimism/op-service/eth"
 	"github.com/ethereum-optimism/optimism/op-service/txmgr"
+	"github.com/ethereum/go-ethereum/accounts/abi/bind"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core/types"
 	"github.com/ethereum/go-ethereum/rlp"
@@ -61,13 +62,12 @@ func (b *BlobTransactionBuilder) BuildOntake(
 	txListBytesArray [][]byte,
 ) (*txmgr.TxCandidate, error) {
 	// Check if the current L2 chain is after ontake fork.
-	// TODO: query from protocol.
-	l2Head, err := b.rpc.L2.BlockNumber(ctx)
+	_, slotB, err := b.rpc.GetProtocolStateVariablesOntake(&bind.CallOpts{Context: ctx})
 	if err != nil {
 		return nil, err
 	}
 
-	if !b.chainConfig.IsOntake(new(big.Int).SetUint64(l2Head)) {
+	if !b.chainConfig.IsOntake(new(big.Int).SetUint64(slotB.NumBlocks)) {
 		return nil, fmt.Errorf("ontake transaction builder is not supported before ontake fork")
 	}
 

diff --git a/packages/taiko-client/proposer/transaction_builder/fallback.go b/packages/taiko-client/proposer/transaction_builder/fallback.go
@@ -150,7 +150,6 @@ func (b *TxBuilderWithFallback) BuildOntake(
 }
 
 // BuildPacaya implements the ProposeBlocksTransactionBuilder interface.
-// TODO: improve this method to use func interface.
 func (b *TxBuilderWithFallback) BuildPacaya(
 	ctx context.Context,
 	txBatch []types.Transactions,