Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): Based Contestable Rollup - alpha-6/Katla #15316

Closed
wants to merge 149 commits into from

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Dec 3, 2023

  • Apply fixes based on OZ's inspector reports
  • Grant securityCouncil the PROPOSER role
  • Use taikoL2's address as the treasury address in circuit
  • Use Bridge to send cross-chain owned contract transactions
  • Update and fix typescript-linting
  • Non-recursive abi.encode for Zk Verifier
  • Fix a security issue in bridge
  • Update the PlonkVerifier
  • Add improvements and fix bugs in bridge-ui-v2
  • Fix bridged token transfer check
  • Fix bug in L2 pre-deployment script to init immutable variable __self for all EssentialContracts (otherwise, L2 predeployed contracts cannot be upgraded)
  • Fixe duplicate hook issue and prover-fee payment bug
  • Restrict call to SgxVerifier to TaikoL1 and SgxAndPseVerifier.
  • Use EIP-712 style hashing in SgxVerifier
  • Optimize block proving code
  • Add strick price support to TimelockTokenPool

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview Feb 8, 2024 9:00am
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Feb 8, 2024 9:00am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Feb 8, 2024 9:00am

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 300 lines in your changes are missing coverage. Please review.

Comparison is base (1eaa963) 27.42% compared to head (739a268) 27.36%.

Files Patch % Lines
packages/eventindexer/generator/generator.go 0.00% 207 Missing ⚠️
packages/eventindexer/api/api.go 0.00% 60 Missing ⚠️
packages/eventindexer/pkg/repo/chart.go 60.86% 7 Missing and 2 partials ⚠️
...ackages/eventindexer/pkg/http/get_chart_by_task.go 0.00% 7 Missing ⚠️
packages/eventindexer/pkg/repo/event.go 0.00% 5 Missing and 1 partial ⚠️
packages/eventindexer/pkg/repo/nft_balance.go 0.00% 6 Missing ⚠️
packages/eventindexer/pkg/repo/stat.go 66.66% 2 Missing ⚠️
.../eventindexer/indexer/save_block_assigned_event.go 0.00% 1 Missing ⚠️
...indexer/indexer/save_transition_contested_event.go 0.00% 1 Missing ⚠️
...entindexer/indexer/save_transition_proved_event.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           based_contestable_zkrollup   #15316      +/-   ##
==============================================================
- Coverage                       27.42%   27.36%   -0.06%     
==============================================================
  Files                              77       99      +22     
  Lines                            4923     5795     +872     
==============================================================
+ Hits                             1350     1586     +236     
- Misses                           3426     4041     +615     
- Partials                          147      168      +21     
Flag Coverage Δ *Carryforward flag
eventindexer 17.28% <7.69%> (-1.09%) ⬇️ Carriedforward from 480d61b
guardian-prover-health-check 36.13% <ø> (?)
relayer 40.58% <ø> (+0.60%) ⬆️ Carriedforward from 480d61b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@leotese leotese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good

@cyberhorsey
Copy link
Contributor

It's good

please don't approve or spam our GitHub. thank you.

@dionysuzx dionysuzx closed this Feb 9, 2024
@dionysuzx dionysuzx deleted the alpha-6 branch February 9, 2024 02:26
@dionysuzx dionysuzx restored the alpha-6 branch February 10, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.