feat(relayer): Add flag to be able to index past blocks to crawl for missed messages #15547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## alpha-6 #15547 +/- ##
===========================================
- Coverage 27.15% 26.74% -0.42%
===========================================
Files 94 97 +3
Lines 5700 5908 +208
===========================================
+ Hits 1548 1580 +32
- Misses 3988 4156 +168
- Partials 164 172 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RogerLamTd
approved these changes
Jan 24, 2024
davidtaikocha
approved these changes
Jan 25, 2024
This was referenced Feb 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where a message is missed when indexing, or perhaps needs to be picked up again. These situations have arisen in the current testnet, and seem to be related to the restarting of the processors. It is also possible for a relayer to have an issue processing a message for a variety of reasons (gas, misseed transaction, nonce out of order, etc), although unlikely.
It would be best to have a second set of indexers running, that crawl older blocks, and find any unprocessed-but-processable messages (messages that still have EventStatus New), and re-add them to the same queue that the processors pick up from.
This secondary mode will ensure robustness of the bridge relayer for mainnet.