Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(relayer): Relayer proof flag for supporting RLP encoding proof or not #15640

Merged
merged 34 commits into from
Feb 9, 2024

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Feb 2, 2024

Note that after alpha-6 is deprecated, all RLPEncoding code will be removed, and so will the flag, since we will only have one encoding style.

This is simply to support both types of Bridges, so we can perform an upgrade of the SignalService while testing.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Feb 6, 2024 3:24am

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (alpha-7@ab82ffb). Click here to learn what that means.

❗ Current head 524d49a differs from pull request most recent head db4ec21. Consider uploading reports for the commit db4ec21 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             alpha-7   #15640   +/-   ##
==========================================
  Coverage           ?   26.71%           
==========================================
  Files              ?      102           
  Lines              ?     6259           
  Branches           ?        0           
==========================================
  Hits               ?     1672           
  Misses             ?     4404           
  Partials           ?      183           
Flag Coverage Δ *Carryforward flag
eventindexer 17.28% <0.00%> (?) Carriedforward from 739a268
guardian-prover-health-check 36.13% <0.00%> (?) Carriedforward from 739a268
relayer 36.35% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyberhorsey cyberhorsey added this pull request to the merge queue Feb 9, 2024
Merged via the queue into alpha-7 with commit 3ba8b6c Feb 9, 2024
16 of 17 checks passed
@cyberhorsey cyberhorsey deleted the relayer_proof_flag branch February 9, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants