refactor(protocol): improve block liveness bond handling #17010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
dantaik
changed the title
refactor(protocol): improve liveness bond return logics
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
changed the title
dantaik
changed the title
dantaik
changed the title
dantaik
changed the title
…aiko-mono into lib_proving_improve_1
This reverts commit 4826eda.
dantaik
changed the title
dantaik
changed the title
Brechtpd
approved these changes
May 7, 2024
davidtaikocha
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on some feedback from OZ.
In this PR, the liveness bond handling logic is unified into one single section of code. When the block is proven for the first time, the liveness bond value associated with the block will be set to 0, regardless if it is returned to the assigned prover.