Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfts): ui-lib integration into taikoon-ui #17220

Merged
merged 48 commits into from
May 22, 2024

Conversation

bearni95
Copy link
Contributor

@bearni95 bearni95 commented May 16, 2024

taikoon-ui integration of ui-lib's footer component

@bearni95 bearni95 changed the title feat(taikoon): ui-lib integration into taikoo-ui feat(taikoon): ui-lib integration into taikoon-ui May 16, 2024
@dantaik dantaik changed the title feat(taikoon): ui-lib integration into taikoon-ui feat(taikoon-ui): ui-lib integration into taikoon-ui May 20, 2024
@bearni95 bearni95 changed the title feat(taikoon-ui): ui-lib integration into taikoon-ui feat(nfts): ui-lib integration into taikoon-ui May 20, 2024
@bearni95 bearni95 mentioned this pull request May 20, 2024
5 tasks
@bearni95 bearni95 marked this pull request as ready for review May 20, 2024 17:35
@dionysuzx
Copy link
Collaborator

dionysuzx commented May 21, 2024

@bearni95 i think you need to update your scope in the PR title

update: i did it for you

@dionysuzx dionysuzx changed the title feat(nfts): ui-lib integration into taikoon-ui feat(taikoon-ui): ui-lib integration into taikoon-ui May 21, 2024
@bearni95 bearni95 changed the title feat(taikoon-ui): ui-lib integration into taikoon-ui feat(nfts): ui-lib integration into taikoon-ui May 21, 2024
@bearni95
Copy link
Contributor Author

@bearni95 i think you need to update your scope in the PR title

update: i did it for you

We removed taikoon as a valid title index, using nfts now as it's also the package that contains both Taikoons and Snaefell nfts

@bearni95 bearni95 requested review from dantaik and KorbinianK May 22, 2024 10:39
@bearni95 bearni95 added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 849a3c4 May 22, 2024
7 checks passed
@bearni95 bearni95 deleted the ui-lib-taikoon-ui-integration branch May 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants