feat(protocol): add solver support for l2 to l1 eth bridging #18805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: xiaodino <[email protected]>
Co-authored-by: xiaodino <[email protected]> Co-authored-by: Daniel Wang <[email protected]> Co-authored-by: dantaik <[email protected]>
Co-authored-by: xiaodino <[email protected]>
dantaik
reviewed
Jan 27, 2025
packages/protocol/contracts/shared/bridge/EtherBridgeWrapper.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/shared/bridge/EtherBridgeWrapper.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/shared/bridge/EtherBridgeWrapper.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/shared/bridge/EtherBridgeWrapper.sol
Outdated
Show resolved
Hide resolved
packages/protocol/contracts/shared/bridge/EtherBridgeWrapper.sol
Outdated
Show resolved
Hide resolved
|
Solver logic for eth has been merged into |
dantaik
reviewed
Feb 4, 2025
|
@dantaik @cyberhorsey Would you mind managing the conflicts here? I am not sure where did these turn up from |
|
@AnshuJalan I helped you with the conflicts, but please double check if some of your changes are deleted by mistake :D |
dantaik
approved these changes
Feb 10, 2025
YoGhurt111
approved these changes
Feb 10, 2025
smtmfft
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of #18616 for L2 -> L1 FnS ETH bridging.
Bridge.sol. Thus, the Bridge contract itself acts as the “ether vault”.Bridge.solto incorporate a solver condition, but that would fundamentally change the core of the message passing system. Therefore, a better alternative implemented in this PR is a separateEtherBridgeWrapper.solthat handles just the “Eth in” and “Eth out” part of bridging by including a solver condition, leaving the existing functionality ofBridge.soland surrounding infra untouched.Bridge.solcan still be used for standard slow withdrawals.