feat(protocol): make more addresses in protocol immutable #18924
+530
−395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaikocha
changed the title
TaikoInbox and ProverSet immutable
davidtaikocha
commented
Feb 12, 2025
Comment on lines
-525
to
-536
|
|
||
| vm.startPrank(Alice); | ||
| params.proposer = operator; | ||
| vm.expectRevert(ITaikoInbox.NotInboxWrapper.selector); | ||
| inbox.proposeBatch(abi.encode(params), "txList"); | ||
| vm.stopPrank(); | ||
|
|
||
| vm.startPrank(operator); | ||
| params.proposer = address(0); | ||
| vm.expectRevert(ITaikoInbox.CustomProposerMissing.selector); | ||
| inbox.proposeBatch(abi.encode(params), "txList"); | ||
| vm.stopPrank(); |
There was a problem hiding this comment.
Sounds good. I will take a look at how to add them back.
davidtaikocha
commented
Feb 12, 2025
| store = deployProxy({ | ||
| name: "forced_inclusion_store", | ||
| impl: address( | ||
| new ForcedInclusionStore( | ||
| uint8(vm.envUint("INCLUSION_WINDOW")), | ||
| uint64(vm.envUint("INCLUSION_FEE_IN_GWEI")), | ||
| taikoInbox, | ||
| taikoWrapper | ||
| address(1) |
There was a problem hiding this comment.
Since there is a cycle dependency issue for ForcedInclusionStore.constructor and TaikoWrapper.constructor, so have to create a store with fake taikoWrapper address at first here, and do another proxy upgrade below @dantaik @xiaodino @YoGhurt111
There was a problem hiding this comment.
Actually we can deploy two empty proxies to get their addresses, then call upgradeToAndCall on both proxies.
davidtaikocha
changed the title
TaikoInbox and ProverSet immutable
davidtaikocha
requested review from
YoGhurt111,
dantaik,
xiaodino and
cyberhorsey
|
Why don't we continue using the resolver? |
xiaodino
approved these changes
Feb 13, 2025
dantaik
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #18913
TaikoInboxProverSetBridgedERC1155/BridgedERC721