Skip to content

[Don't Merge]chore(protocol): add new environment configurations and enhance README#21447

Open
smtmfft wants to merge 2 commits intomainfrom
update-verifier-script
Open

[Don't Merge]chore(protocol): add new environment configurations and enhance README#21447
smtmfft wants to merge 2 commits intomainfrom
update-verifier-script

Conversation

@smtmfft
Copy link
Contributor

@smtmfft smtmfft commented Mar 9, 2026

No description provided.

@smtmfft smtmfft changed the title feat(sgx-verifier): add new environment configurations and enhance RE… chore(protocol): add new environment configurations and enhance RE… Mar 9, 2026
@claude
Copy link

claude bot commented Mar 9, 2026

Claude finished @smtmfft's task in 1m 17s —— View job


PR Review

  • Gathering context
  • Reviewing changes
  • Posting feedback

Summary

This PR adds new environment configurations (shasta, transition-*, mainnet-shasta-*) to the SGX verifier script and adds a helpful "Querying/Verifying" section to the README. A few issues to address:


Issues

Bug: Duplicate pattern in case statement (configure_sgx_verifier.sh:80)

dev-shasta-sgxgeth|dev-shasta-sgxgeth)

Both alternatives are identical — one is redundant. This is almost certainly a typo; one was likely meant to be dev-shasta-sgxreth or the combined pattern dev-shasta|dev-shasta-sgxreth was intended. Fix this →

New environments missing from help text (configure_sgx_verifier.sh:32-36 and :157-162)

The usage() function and the *) error fallback both list available environments, but neither was updated to include the new shasta and transition variants. Users who pass --help or an invalid env name will see a stale list. Fix this →%22%20error%20fallback%20(lines%20157-162)%20to%20include%20the%20new%20environments%3A%20dev-shasta%2C%20dev-shasta-sgxgeth%2C%20tolba-shasta%2C%20tolba-shasta-sgxgeth%2C%20transition-pacaya-sgxreth%2C%20transition-pacaya-sgxgeth%2C%20transition-shasta-sgxreth%2C%20transition-shasta-sgxgeth%2C%20mainnet-shasta-sgxreth%2C%20mainnet-shasta-sgxgeth.%20Branch%3A%20update-verifier-script&repo=taikoxyz/taiko-mono)

README lists environments that don't exist in the script (README.md:108-110)

The "Hekla Testnet" section references hekla-ontake, hekla-pacaya, hekla-sgxgeth, hekla-pacaya-sgxreth, hekla-pacaya-sgxgeth — none of these are defined in load_env(). Same for tolba-ontake (line 114). Either these should be added to the script or removed from the README.

README missing transition-* environments

transition-pacaya-sgxreth, transition-pacaya-sgxgeth, transition-shasta-sgxreth, transition-shasta-sgxgeth are added to the script but not documented anywhere in the README. The new dev-shasta-*, tolba-shasta-*, and mainnet-shasta-* variants are also absent from the "Predefined Environments" table. Fix this →


Minor Nit

The querying instructions in the README (line 152-157) are useful, but the placeholder <SGX_VERIFIER> and <RPC> style differs from the 0x... style used elsewhere. Minor consistency issue, not a blocker.

@smtmfft smtmfft changed the title chore(protocol): add new environment configurations and enhance RE… chore(protocol): add new environment configurations and enhance README Mar 9, 2026
@smtmfft smtmfft changed the title chore(protocol): add new environment configurations and enhance README [Don't Merge]chore(protocol): add new environment configurations and enhance README Mar 9, 2026
@smtmfft
Copy link
Contributor Author

smtmfft commented Mar 9, 2026

Dont merge until @YoGhurt111 updated the transition shasta verifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant