chore(deps): bump ws from 6.2.3 to 6.2.6 - #21974
Conversation
Bumps [ws](https://github.com/websockets/ws) from 6.2.3 to 6.2.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.6) --- updated-dependencies: - dependency-name: ws dependency-version: 6.2.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 627c79c66b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| version: https://codeload.github.com/Vectorized/solady/tar.gz/30f9389cd42a405a3536cabc76de2de89d9c6a94 | ||
| sp1-contracts: | ||
| specifier: github:succinctlabs/sp1-contracts#v6.1.1 | ||
| version: https://codeload.github.com/succinctlabs/sp1-contracts/tar.gz/d3629729c3216eb51bd4859d027a8eb729399fa4 | ||
| version: https://codeload.github.com/succinctlabs/sp1-contracts/tar.gz/2ac7311ccc5b400dc7773727ec0d15eb9ff1cfa0 |
There was a problem hiding this comment.
Keep protocol Git dependencies pinned
When this ws lockfile patch is merged, packages/protocol installs different smart-contract dependencies even though no package.json spec changed: solady moves from acd959aa... to 30f9389c..., and sp1-contracts moves from d3629729... to 2ac7311c.... Because these packages provide contract/prover-verifier source used by the protocol build and tests, a websocket security bump would silently change audited protocol inputs; please revert these unrelated Git ref updates or split them into a separately reviewed dependency change.
Useful? React with 👍 / 👎.
|
Closing: the regenerated pnpm-lock.yaml in this bump also retargets packages/protocol's git dependencies (forge-std, solady) to newer commits, because they are declared with unpinned refs (e.g. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps ws from 6.2.3 to 6.2.6.
Release notes
Sourced from ws's releases.
Commits
dd3ae14[dist] 6.2.6899bf9e[fix] Reset the fragment counter when the message is complete1a0afaf[dist] 6.2.54f19c0c[fix] Lower default values ofmaxBufferedChunksandmaxFragments58ddc8c[fix] Count empty fragments toward the limit (#2329)86d3e8a[dist] 6.2.4a76e211[security] Limit retained message partsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.