Refactor language service setup and usage #1271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/source-not
branch
from
1b26cf3 to
8b18f8f
Compare
thecrypticace
force-pushed
the
feat/refactor-language-service-usage
branch
from
bb0d657 to
379df94
Compare
thecrypticace
force-pushed
the
feat/refactor-language-service-usage
branch
from
379df94 to
19bb723
Compare
This will set us up for more direct, language-service specific testing. This is very much a work in progress but the ultimate goal is for the majority of language server tests to be able to run against both the language service _and_ language server
Protocol v3.17 added support for pull-model diagnostics which are modeled as a “report” that is either a full set of diagnostics for a document (and related documents) or “unchanged” We can convert these to the push model by pulling the diagnostics like we were doing before and inspecting the report before pushing diagnostics to the client
Most relevant requests are document related in some manner and this will serve a few purposes: - It centralizes logic common to all providers - It can help simplify the implementation of providers - It reduces duplication by moving common actions into the document creation layer (e.g. loading settings)
This uses the new virtual document abstraction to simplify the implementation of the provider. Now it operates only on things it cares about: - utility class names - CSS helper functions
thecrypticace
force-pushed
the
feat/refactor-language-service-usage
branch
from
e98013a to
3072ca5
Compare
thecrypticace
changed the title
thecrypticace
force-pushed
the
feat/refactor-language-service-usage
branch
from
c5e0748 to
0f172a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this up b/c I ended up accidentally doing a refactor (lol) and don't want to forget to merge it
This sets up architecture that should (eventually) help with more direct testing in the language service itself. My primary goal here is for the majority of language server tests to be able to run against both the language service and language server where it makes sense.