Skip to content

Implement better calc(…) evaluation for completions and equivalents #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: fix/class-functions-hover-in-script-tags
Choose a base branch
from

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Apr 14, 2025

Fixes #1314

  • Investigate the change to the TS config as I feel like it should not be necessary
  • Manually verify the stated case from the issue above is addressed

Hovers:
Screenshot 2025-04-14 at 13 29 26

Completions:
Screenshot 2025-04-14 at 13 30 21

@thecrypticace
Copy link
Contributor Author

The types change is basically because the types only exist for the ESM exports for those packages. NodeNext/Node16 resolution works for ESM but not for CJS which is maybe the issue.

The language isn't currently declared as "type": "module" though it actually should be b/c that's the bundled format. I'll make that change when we do the node version bump + service refactor.

@thecrypticace thecrypticace marked this pull request as ready for review April 15, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant