Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset <th> alignment & font weight #15380

Closed

Conversation

MartijnCuppens
Copy link
Contributor

@MartijnCuppens MartijnCuppens commented Dec 12, 2024

Set the <th> alignment to inherit rather than centering it. Also reset the font weight like we do with h1,h2,...

Demo: https://codepen.io/MartijnCuppens/pen/PoqjNxx

Bootstrap reference: twbs/bootstrap#30323
Issue with Safari: whatwg/html#7978
Resolved issue: https://bugs.webkit.org/show_bug.cgi?id=138577 (you can check it with the codepen demo)

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner December 12, 2024 17:20
@MartijnCuppens MartijnCuppens changed the title Reset <th> alignment Reset <th> alignment & font weight Dec 13, 2024
@BraveNima
Copy link

how so

@philipp-spiess
Copy link
Member

@MartijnCuppens Hey! It seems like this was fixed in Safari in 2022 or am I missing something?

Screenshot 2025-02-26 at 11 22 25

Since Tailwind CSS v4 requires Safari 16.4+ (from March 2023), it seems like this change is no longer necessary so I'm going to close this PR but feel free to show me otherwise. Thank you!

@MartijnCuppens
Copy link
Contributor Author

Yup, the issue with Safari is changed, that's why twbs/bootstrap#30323 wasn't needed anymore.

This PR was about resetting the alignment and font weight of table headings, so that they are not centered and bold anymore. Definitely a breaking change btw, but It felt more consistent with h1,h2,... which have their font weight reset too.

@philipp-spiess
Copy link
Member

Ahh gotcha I misunderstood. Yeah I think the ship for shipping that has kinda sailed for now, that's definitely a bigger breaking change and would require a v5 release :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants