Merged
Conversation
This way it is only executed once per `node` and will be cached afterwards. Before that, this was happening every time.
RobinMalfait
changed the title
philipp-spiess
approved these changes
Feb 5, 2025
Contributor
philipp-spiess
left a comment
philipp-spiess
left a comment
There was a problem hiding this comment.
Oh, found a whoopsie there huh 😅
Member
Author
|
@philipp-spiess haha just a nice feeling when you move some code around and improve performance 😅 |
RobinMalfait
deleted the
feat/improve-substitute-functions-performance
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a performance improvement we noticed while working on on: #16211
We noticed that
substituteFunctionswas being called on everynodeafter thecompileAstNodeswas done. However, thecompileAstNodesis heavily cached.By moving the
substituteFunctionswe into the cachedcompileAstNodeswe sped up performance for Catalyst rebuilds from ~15ms to ~10ms.