Value types field setting consistency checks #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikser
commented
Aug 16, 2018
runtime/bcverify/rtverify.c
Outdated
| /* cannot set value type to null | ||
| * TODO: proper exception */ | ||
| printf("BIG ERROR\n"); | ||
| goto _inconsistentStack; |
There was a problem hiding this comment.
Other than an NLS message, how should I implement the exception throwing? I notice there are some constants defined for the verboseErrorCode in j9consts.h, but are these mapped to something?
There was a problem hiding this comment.
ya they used in errormessageframeworkrtv.c.
I think in this case it would be better to use the _miscError target and add your own errorcode (similar to BCV_ERR_BAD_ACCESS_PROTECTED)
Signed-off-by: Mohammad Ali Nikseresht <[email protected]>
anikser
force-pushed
the
vt-field-attribute-membership
branch
2 times, most recently
from
d460b8c to
13fc6a5
Compare
Value type fields are non-nullable - this check can be performed during bytecode verification for some cases, ie. when aconst_null appears immediately before putfield. Signed-off-by: Mohammad Ali Nikseresht <[email protected]>
anikser
force-pushed
the
vt-field-attribute-membership
branch
2 times, most recently
from
a2d1634 to
05047fb
Compare
Withfield can only operate on a value type class field, and putfield and putstatic cannot operate on a value type class field. Signed-off-by: Mohammad Ali Nikseresht <[email protected]>
anikser
force-pushed
the
vt-field-attribute-membership
branch
from
05047fb to
de86920
Compare
tajila
pushed a commit
that referenced
this pull request
Jun 21, 2019
Added wrapper for image memory allocate and image memory free
tajila
pushed a commit
that referenced
this pull request
Mar 13, 2020
Implment monitor enter/exit for valuetypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements consistency checking for value type related field setting. A hash table of the names listed in a class's ValueTypes attribute is created, and used to perform the following checks during runtime bytecode verification:
during bytecode verification for some cases, ie. when aconst_null
appears immediately before putfield.
Also add a couple missing
#if definedstatements in field setting bytecode verification.