Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messageField.visible param added #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victor-suri
Copy link

Created the MessageField param related to the visible property in JS SDK. Currently in JS SDK we have two options:

  • a boolean value or
  • a conversation predicate, a function that process a value and use it as the property

In flutter we really don't need the conversation predicate, since we already have the conversation itself to pass the ChatBox when building the chat.

@bugnano
Copy link
Collaborator

bugnano commented Apr 10, 2023

Thank you for contributing to our Flutter SDK.

Before we accept any patches, we require every contributor to sign either the individual or the corporate CLA and email it to [email protected]

Regarding your comment that we don't need the conversation predicate, I'm not entirely sure about it, the Flutter SDK tries to mimic the JS SDK as much as possible, and the fact that the conversation predicate isn't required by your application doesn't necessarily mean that it will never be required by any other application that uses this SDK.

The fact that the visible parameter has been omitted until now is because Dart doesn't support union types (correct me if I'm wrong here, maybe now it does), and I have yet to find a way to implement this feature cleanly without union types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants