Skip to content

Conversation

@talregev
Copy link
Owner

@talregev talregev commented Aug 28, 2025

GeographicLib from vendor gtsam

This mean that the GeographicLib will not build with "all" target. also it mean it will not build everything in GeographicLib. only when it needed (on navigation tests) and what it needed (the lib itself).
This save from the javascript compilation error that occur otherwise.

@talregev talregev force-pushed the TalR/geo branch 20 times, most recently from 88d7985 to e20460a Compare August 28, 2025 18:29
@talregev talregev changed the title GeographicLib from system GeographicLib from vendor gtsam Aug 28, 2025
add_subdirectory(GeographicLib)
add_subdirectory(
GeographicLib
EXCLUDE_FROM_ALL
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mean that the GeographicLib will not build with "all" target. also it mean it will not build everything in GeographicLib. only when it needed (on navigation tests) and what it needed (the lib itself).
This save from the javascript compilation error that occur otherwise.

@talregev talregev force-pushed the TalR/geo branch 2 times, most recently from bc674a4 to 6c6e1aa Compare August 28, 2025 20:27
@talregev
Copy link
Owner Author

talregev commented Aug 28, 2025

These lines imply that GeographicLib is install when it not found the GeographicLib in system. In practice it not activate the install even if it not found the GeographicLib in system.

I want to delete these line, and set the option to be default false. (similar the state it has today).
If you approve, I will create another push for that.

if(GEOGRAPHICLIB-NOTFOUND)
set(install_geographiclib_default ON)
else()
set(install_geographiclib_default OFF)
endif()
option(GTSAM_INSTALL_GEOGRAPHICLIB "Build and install the 3rd-party library GeographicLib" ${install_geographiclib_default})

@talregev talregev closed this Aug 29, 2025
@talregev talregev deleted the TalR/geo branch August 29, 2025 04:18
@talregev talregev restored the TalR/geo branch August 29, 2025 04:18
@talregev talregev deleted the TalR/geo branch October 9, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants