Move to ignore for ignoring files
#640
Conversation
| bldr.git_ignore(true) | ||
| .git_exclude(true) | ||
| .git_global(true) | ||
| .ignore(true) | ||
| .hidden(false) | ||
| .same_file_system(true); |
There was a problem hiding this comment.
I feel the same as you that obeying gitignore rules is likely a desired behavior and i personally have nothing against this becoming the default behavior (one day)
however, I agree with @panekj #619 (comment) that this can be viewed as a breaking change, so would be better to have this as an opt-in feature, at least for now.
Also, given how ignore API is designed -- some ignore rules by default -- the walk builder should be configured with standard_filters(false) first, then enable what we want.
Question
is switching to ignore create sufficient to prune large target directly without recursing to it?
There was a problem hiding this comment.
is switching to ignore create sufficient to prune large target directly without recursing to it?
Yes it is
|
Any chance this could get merged soon? With this PR, it goes down to <200ms (might need to be rebased) |
|
I am happy to rebase if there is a clear intent to merge it |
Closes #619
A pragmatic and practical fix to slow performance on directories with large
targetdirs et.al. (form doesn't terminate to milliseconds for 100GB+targetdirectory)Also avoids a bunch of unnecessary
collections and passes around an iterator instead, with the according file rename.