Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about MBTiles sources #233

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Add information about MBTiles sources #233

merged 3 commits into from
Oct 30, 2017

Conversation

matteblair
Copy link
Member

@matteblair matteblair commented Oct 29, 2017

Documents how Tangram ES can load tilesets from MBTiles databases.

Since we load vector tile formats, we don't strictly follow version 1.1 of the spec. Our implementation actually follows the proposed version 2.0 of the spec (mapbox/mbtiles-spec#46). I can update these docs when/if those changes to the spec are merged.

Resolves #192

@matteblair
Copy link
Member Author

@tallytalwar Can you check that this makes sense? If so I think we can go ahead and merge it.

Copy link
Member

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change requested.

pages/sources.md Outdated
@@ -141,6 +141,23 @@ mapbox:
url: https://a.tiles.mapbox.com/v4/mapbox.mapbox-streets-v6-dev/{z}/{x}/{y}.vector.pbf?access_token=...
```

##### MBTiles

[[ES-only](https://github.com/tangrams/tangram-es)] If the _URL_ of a data source has a file extension of `.mbtiles` then the specified file will be accessed as an MBTiles database and used as a tile set according to version 1.1 of the MBTiles specification: https://github.com/mapbox/mbtiles-spec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of version 1.1, probably we should mention according to the proposed version 2.0 of the MBTiles spec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes more sense, updated.

@matteblair matteblair merged commit 7f5eec5 into gh-pages Oct 30, 2017
@matteblair matteblair deleted the mbtiles-sources branch October 30, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants