Update the 'Creating your first Tarantool database' guide #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuniq
force-pushed
the
gh-3704-create-db-guide
branch
from
a93ade8 to
9d642c1
Compare
xuniq
force-pushed
the
gh-3704-create-db-guide
branch
from
5647fb0 to
539a482
Compare
xuniq
force-pushed
the
gh-3704-create-db-guide
branch
from
539a482 to
a1214dd
Compare
Totktonada
reviewed
Dec 20, 2023
Totktonada
reviewed
Dec 20, 2023
Totktonada
reviewed
Dec 20, 2023
Totktonada
reviewed
Dec 20, 2023
doc/how-to/getting_started_db.rst
Outdated
Comment on lines
232
to
228
| The ``listen`` value can be any form of a :ref:`URI <index-uri>` (uniform resource identifier). | ||
| You can send requests to the listen URI using: |
Totktonada
reviewed
Dec 20, 2023
doc/how-to/getting_started_db.rst
Outdated
| You can send requests to the listen URI using: | ||
|
|
||
| * ``telnet`` | ||
| * a :ref:`connector <index-box_connectors>` | ||
| * another instance of Tarantool (using the :ref:`console <console-module>` module) | ||
| * :ref:`tt <tt-cli>` administrative utility |
Contributor
There was a problem hiding this comment.
I guess it is for a control (console) socket. iproto.listen is about a binary protocol socket. You can't work with it using telnet.
OTOH, you can't use a connector to connect to a console (not a binary protocol socket).
Maybe we should describe it in a more general context, not just iproto.listen?
Totktonada
approved these changes
Dec 20, 2023
Contributor
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
I'm OK in general.
Highlighted several chunks that doubt me a bit.
xuniq
force-pushed
the
gh-3704-create-db-guide
branch
from
02c8888 to
048f4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3704
Staging: https://docs.d.tarantool.io/en/doc/gh-3704-create-db-guide/how-to/getting_started_db/