Skip to content

replication.synchro_queue_max_size configuration option #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

@maryiaLichko maryiaLichko self-assigned this Jan 28, 2025
@maryiaLichko
Copy link
Contributor Author

@p7nov hey! please take a look

p7nov

This comment was marked as resolved.

Copy link

@Astronomax Astronomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In essence, everything is correct. I think it's useful to also say: "The size limit isn't strict, i.e. if there's at least one free byte, the whole write request fits and no blocking is involved."

@maryiaLichko
Copy link
Contributor Author

maryiaLichko commented Jan 31, 2025

There is a bit of a mess with commits and changes. Please fix it leaving only the related changes.

@p7nov pls help with this. I don't know how should I resolve it, sorry :)

@maryiaLichko maryiaLichko requested review from p7nov and veod32 February 3, 2025 10:38
@maryiaLichko maryiaLichko force-pushed the gh-4575-rep-queue-max-size branch from 2c109a4 to 24a8077 Compare April 4, 2025 08:23
@maryiaLichko maryiaLichko removed the request for review from p7nov April 4, 2025 08:24
@maryiaLichko maryiaLichko force-pushed the gh-4575-rep-queue-max-size branch from f13ab07 to 93f606d Compare April 4, 2025 08:27
@maryiaLichko maryiaLichko merged commit 41a65d6 into latest Apr 4, 2025
1 check passed
@maryiaLichko maryiaLichko deleted the gh-4575-rep-queue-max-size branch April 4, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new configuration option: 'replication.synchro_queue_max_size'
3 participants