Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: add Instance info to ConnectionInfo #429

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

KaymeKaydex
Copy link

The Instance info has been added to ConnectionInfo, which is necessary to monitor the current state of the pool. This should help implement dynamic tracking of tarantool topology changes.

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Related issues:

@oleg-jukovec oleg-jukovec requested a review from DerekBum February 4, 2025 10:42
@KaymeKaydex KaymeKaydex force-pushed the more-info branch 3 times, most recently from 2d27324 to bcdf9c7 Compare February 4, 2025 11:26
Copy link

@themilchenko themilchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Left a couple of minor comments below.

@themilchenko
Copy link

A commit message looks very long. Please, format it to 72 characters per line.

Reference: https://www.tarantool.io/en/doc/latest/contributing/developer_guidelines/

@KaymeKaydex KaymeKaydex closed this Feb 5, 2025
@KaymeKaydex
Copy link
Author

Instance info in ConnectionInfo enables pool state monitoring and dynamic tarantool topology tracking.
@oleg-jukovec oleg-jukovec removed the request for review from DerekBum February 6, 2025 16:21
Comment on lines +3510 to +3514
tCases = append(tCases, makeInstances([]string{
servers[0],
servers[1],
servers[3]},
connOpts))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tCases = append(tCases, makeInstances([]string{
servers[0],
servers[1],
servers[3]},
connOpts))
tCases = append(tCases, makeInstances([]string{
servers[0],
servers[1],
servers[3],
}, connOpts))

Nit, up to you.

@oleg-jukovec oleg-jukovec merged commit 5368646 into tarantool:master Feb 7, 2025
20 checks passed
@oleg-jukovec oleg-jukovec mentioned this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants