feat: initial implementation of go-tlog with examples, CI and README #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial project setup: - Added logger core (level, format, stacktrace, internal outputs) - Added tests for core logger functionality - Added examples (stdout, stderr, file) - Added GitHub Actions CI workflow - Added README and LICENSE (BSD 2-Clause) - Added .golangci.yml and .gitignore
vakhov
force-pushed
the
vakhov/initial-version
branch
from
d2eb898 to
6e31ef2
Compare
oleg-jukovec
requested changes
Nov 13, 2025
_examples/file/main.go
Outdated
There was a problem hiding this comment.
It is better to make testable examples in Golang: https://go.dev/blog/examples
- This is an idiomatic approach.
- The examples will be showed in the documentation.
README.md
Outdated
Comment on lines
2
to
3
| [Telegram EN](https://t.me/tarantool) • | ||
| [Telegram RU](https://t.me/tarantoolru) |
There was a problem hiding this comment.
Some budgets are without images that looks bad. You could copy-paste approach from here:
vakhov
force-pushed
the
vakhov/initial-version
branch
from
148dbe1 to
6c9e010
Compare
vakhov
force-pushed
the
vakhov/initial-version
branch
from
6c9e010 to
21269a5
Compare
oleg-jukovec
requested changes
Nov 28, 2025
| branches: [ '**' ] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
We need a linter job too. See go-discovery/go-storage/go-tarantool etc.
Comment on lines
94
to
95
|
|
||
| func (o *Outputs) Write(p []byte) (int, error) { |
Comment on lines
27
to
28
|
|
||
| func (b *buffer) Free() { |
There was a problem hiding this comment.
The same about comment to public calls: missed.
Comment on lines
+1
to
+3
| // Copyright 2022 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. |
There was a problem hiding this comment.
We should use a correct copyright and mention the Go authors in the project's LICENSE file if so.
oleg-jukovec
requested changes
Nov 28, 2025
Makefile
Outdated
Comment on lines
34
to
39
| ## Run all _examples to ensure they compile and run without panic | ||
| examples: | ||
| $(GO) run ./_examples/stdout | ||
| $(GO) run ./_examples/stderr >/dev/null 2>&1 || true | ||
| $(GO) run ./_examples/file | ||
| $(GO) run ./_examples/multi |
There was a problem hiding this comment.
Suggested change
| ## Run all _examples to ensure they compile and run without panic | |
| examples: | |
| $(GO) run ./_examples/stdout | |
| $(GO) run ./_examples/stderr >/dev/null 2>&1 || true | |
| $(GO) run ./_examples/file | |
| $(GO) run ./_examples/multi |
Co-authored-by: Oleg Jukovec <[email protected]>
Co-authored-by: Oleg Jukovec <[email protected]>
Co-authored-by: Oleg Jukovec <[email protected]>
vakhov
force-pushed
the
vakhov/initial-version
branch
from
7d9aa41 to
38470df
Compare
vakhov
force-pushed
the
vakhov/initial-version
branch
from
38470df to
c67ec38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added