Skip to content

bugfix: do not flush out routeMap in bucketSearchBatched #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

bugfix: do not flush out routeMap in bucketSearchBatched #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ CHANGES:
* Add ability to set custom dialer in InstaceInfo.
* Router.Call: retry on VShardErrNameTransferIsInProgress error as in the `vshard` module (#75).

BUG FIXES:
* Router.bucketSearchBatched: do not flush out routeMap (#79).

## v2.0.5

The go-vshard team apologizes for changing the interfaces to experimental status.
Expand Down
2 changes: 1 addition & 1 deletion discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (r *Router) bucketSearchBatched(ctx context.Context, bucketIDToFind uint64)
rs = rsFuture.rs
}

routeMap[bucketID].Store(rs)
routeMap[bucketID].Store(rsFuture.rs)
}

if bucketIDWasFound := rs != nil; !bucketIDWasFound {
Expand Down
Loading