Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: fix error ssl socket support #201

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

themilchenko
Copy link
Contributor

Check of ssl socket support occurs always, even if ssl is disabled.

After the patch support of ssl socket checks only if tls is enabled.

Check of ssl socket support occurs always, even if ssl is disabled.

After the patch support of ssl socket checks only if tls is enabled.
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's better to have a test for the case if it is not too hard (but it looks that it will require a lot of changes in CI and in tests).

@themilchenko
Copy link
Contributor Author

LGTM, but it's better to have a test for the case if it is not too hard (but it looks that it will require a lot of changes in CI and in tests).

Yes, I think that writing a test on this case should done in a separate task.

@oleg-jukovec
Copy link
Contributor

LGTM, but it's better to have a test for the case if it is not too hard (but it looks that it will require a lot of changes in CI and in tests).

Yes, I think that writing a test on this case should done in a separate task.

Up to you, but don't forget to create an issue than please.

@themilchenko themilchenko merged commit 5bfaaf8 into master Nov 12, 2024
34 checks passed
@themilchenko themilchenko deleted the themilchenko/fix-sslsocket-support branch November 12, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants