hooks: forbid direct hook assignment #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locker
reviewed
Dec 1, 2025
mandesero
force-pushed
the
gh-390-hooks
branch
from
c067f10 to
e0ca0b3
Compare
locker
reviewed
Dec 1, 2025
Before this patch luatest accepted two ways to register hooks: * call-style API: `group.before_all(function() ... end)` * direct assignment: `group.before_all = function() ... end` The second form does not work correctly with parametrized tests. We already encountered this on the tarantool side and had to rewrite such assignments in tarantool/tarantool#8187. With this change luatest enforces a single, consistent way to register hooks: * hooks must be registered via calls like `before_each(function() ... end)`, `after_each(function() ... end)`, `before_all(function() ... end)`, `after_all(function() ... end)`, `before_suite(function() ... end)`, `after_suite(function() ... end)`, `before_test('name', function() ... end)` and `after_test('name', function() ... end)`; * assigning to these names (e.g. `group.before_each = fn`) now raises an error with a clear message. Legacy `group.setup` / `group.teardown` remain supported and are not affected by this change. Legacy `group.setup` / `group.teardown` are no longer supported; use `before_each`/`after_each` instead. Closes tarantool#390
mandesero
force-pushed
the
gh-390-hooks
branch
from
e0ca0b3 to
76d9dc9
Compare
locker
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, luatest accepted two ways to register hooks:
group.before_all(function() ... end)group.before_all = function() ... endThe second form does not work correctly with parametrized tests. We already encountered this on the Tarantool side and had to rewrite such assignments in tarantool/tarantool#8187.
With this change, luatest enforces a single, consistent way to register hooks:
before_each(function() ... end)after_each(function() ... end)before_all(function() ... end)after_all(function() ... end)before_suite(function() ... end)after_suite(function() ... end)before_test('name', function() ... end)after_test('name', function() ... end)group.before_each = fn) now raises an error with a clear message.Legacy
group.setup/group.teardownare no longer supported; usebefore_each/after_eachinstead.Closes #390