Skip to content

Proofread the documentation #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

patiencedaur
Copy link
Contributor

@patiencedaur patiencedaur commented Jul 2, 2022

  • Proofread the English language
  • Provide a more human space name
  • Provide the correct translation of the term "space"

Resolves tarantool/doc#2545

@patiencedaur patiencedaur requested a review from Totktonada July 2, 2022 09:22
@LeonidVas LeonidVas requested review from oleg-jukovec and removed request for Totktonada July 5, 2022 09:49
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work! Could you please resolve the notes, please?

@patiencedaur patiencedaur requested a review from oleg-jukovec July 5, 2022 12:15
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes! LGTM after solving two small problems.
You could squash the commits into one if you want.

@oleg-jukovec
Copy link
Contributor

Also, I want to squash the commits but it isn't enabled for this repository:

I meant something like this:
https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits

@patiencedaur patiencedaur force-pushed the patiencedaur/proofread-docs branch from 82d1e3f to d581c79 Compare July 6, 2022 04:20
@patiencedaur
Copy link
Contributor Author

@oleg-jukovec
Copy link
Contributor

I meant something like this:
https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits

@oleg-jukovec Done.

Thank you! To make everything perfect, let's synchronize the commit message with the format used in the repository:

prefix: subject

description

It can be something like that:

docs: proofread

* Proofread the English and Russian language
* Provide a more human space name
* Provide the correct translation of the term "space"

* Proofread the English and Russian language
* Provide a more human space name
* Provide the correct translation of the term "space"
@patiencedaur patiencedaur force-pushed the patiencedaur/proofread-docs branch from d581c79 to ac5fcf7 Compare July 6, 2022 09:41
@oleg-jukovec
Copy link
Contributor

Thank you!

@oleg-jukovec oleg-jukovec merged commit a64147b into master Jul 6, 2022
@oleg-jukovec oleg-jukovec deleted the patiencedaur/proofread-docs branch July 6, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8pt] Proofread Python connector documentation
2 participants