config: allow to call config:get() from app script #8929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
force-pushed
the
gh-8862-use-config-get-from-app-script
branch
from
e67e9d1 to
171a568
Compare
xuniq
approved these changes
Jul 31, 2023
Totktonada
force-pushed
the
gh-8862-use-config-get-from-app-script
branch
from
171a568 to
649132f
Compare
ImeevMA
approved these changes
Aug 1, 2023
The declarative config has the `app` section with following three parameters: * `app.file` -- the path to the script file * `app.module` -- the same, but the script is searched using the Lua search paths (and loaded using `require`) * `app.cfg` -- a user provided configuration (arbitrary map) This commit adds a few success/failure cases. The goal is to have simple test examples to add more ones easier in a future. Implemented several test helpers for typical scenarios that can be used outside of the application script test. Part of tarantool#8862 NO_DOC=testing improvements NO_CHANGELOG=see NO_DOC
It is convenient to access configuration using `config:get()` from the application script (`app.file` or `app.module`). However, before this commit, it was not possible, because the configuration was not considered as applied before the application script is loaded. Now, the script loading is moved into the post-apply phase. The resulting sequence of steps on startup/reload is the following. * collect configuration information (from all the sources) * <if the previous step is failed, set `check_errors` status and break> * apply the configuration (call all the appliers) * <if the previous step is failed, set `check_errors` status and break> * <set the new successful status: `ready` or `check_warnings`> * call post-apply hooks (including application script loading) * <if the previous step is failed, set `check_errors` status and break> * <set the new successful status: `ready` or `check_warnings`> I would like to briefly comment the changes in the tests. * `app_test.lua`: added the check for the new behavior (call config:get() from the app script) * `appliers_test.lua`: fixed the applier call (`.apply` -> `.post_apply`) * `config_test.lua`: fixed status observed in the app script (`*_in_progress` -> `ready`) Part of tarantool#8862 NO_DOC=reflected in tarantool/doc#3544
Totktonada
force-pushed
the
gh-8862-use-config-get-from-app-script
branch
from
649132f to
13b84a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is convenient to access configuration using
config:get()from the application script (app.fileorapp.module).However, before this commit, it was not possible, because the configuration was not considered as applied before the application script is loaded.
Now, the script loading is moved into the post-apply phase.
The resulting sequence of steps on startup/reload is the following.
check_errorsstatus and break>check_errorsstatus and break>readyorcheck_warnings>check_errorsstatus and break>readyorcheck_warnings>Part of #8862
See also a state diagram in tarantool/doc#3544.