Skip to content

config: add metrics section to schema #8943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2023
Merged

config: add metrics section to schema #8943

merged 2 commits into from
Aug 4, 2023

Conversation

Lord-KA
Copy link
Contributor

@Lord-KA Lord-KA commented Aug 3, 2023

This patch introduces all metrics configuration.

Part of #8861

NO_DOC=tarantool/doc#3544 links the most actual schema,
no need to update the issue.

@Lord-KA Lord-KA requested review from a team as code owners August 3, 2023 08:28
@coveralls
Copy link

coveralls commented Aug 3, 2023 •
edited
Loading

Coverage Status

coverage: 86.122% (+0.01%) from 86.108% when pulling d95e5b7 on Lord-KA:Lord-KA/gh-8861-config-add-metrics into 0cb9101
on tarantool:master.

@Lord-KA Lord-KA force-pushed the Lord-KA/gh-8861-config-add-metrics branch from fc2478a to 827a8d7 Compare August 3, 2023 09:55
@Lord-KA Lord-KA requested a review from Totktonada August 3, 2023 09:56
@Lord-KA Lord-KA force-pushed the Lord-KA/gh-8861-config-add-metrics branch from 827a8d7 to db4f6a0 Compare August 3, 2023 09:57
@Lord-KA
metrics: bump to new version
67a894d 
Bump the metrics submodule to 1.0.0-3-4865675c

NO_DOC=metrics submodule bump
NO_TEST=metrics submodule bump
NO_CHANGELOG=metrics submodule bump
@Lord-KA Lord-KA force-pushed the Lord-KA/gh-8861-config-add-metrics branch from db4f6a0 to 5f0553a Compare August 3, 2023 10:00
Totktonada
Totktonada approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The patches look visually good.

I'll add Georgy to also look here.

@Totktonada Totktonada removed their assignment Aug 3, 2023
@Lord-KA Lord-KA force-pushed the Lord-KA/gh-8861-config-add-metrics branch from 5f0553a to 1fe36b8 Compare August 3, 2023 15:00
@Lord-KA Lord-KA added the full-ci Enables all tests for a pull request label Aug 3, 2023
ylobankov
ylobankov approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ylobankov ylobankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM with one nit.

p7nov
p7nov approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestion on the changelog.

@Lord-KA
config: add metrics section to schema
d95e5b7 
This patch introduces all metrics configuration.

Part of tarantool#8861

NO_DOC=tarantool/doc#3544 links the most actual schema,
       no need to update the issue.
@Lord-KA Lord-KA force-pushed the Lord-KA/gh-8861-config-add-metrics branch from 1fe36b8 to d95e5b7 Compare August 4, 2023 07:52
@Totktonada Totktonada merged commit 0b014ad into tarantool:master Aug 4, 2023
@Totktonada Totktonada removed their assignment Aug 4, 2023
@Totktonada Totktonada mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

@ylobankov ylobankov ylobankov approved these changes

@DifferentialOrange DifferentialOrange DifferentialOrange approved these changes

@p7nov p7nov p7nov approved these changes

Assignees
No one assigned
Labels
full-ci Enables all tests for a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Lord-KA @coveralls @Totktonada @ylobankov @DifferentialOrange @p7nov