Add useChat() hook and ChatProvider context #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulla028
requested changes
Feb 12, 2025
| @@ -62,7 +64,7 @@ function CodeHeader({ | |||
| setIsRunning(true); | |||
|
|
|||
| try { | |||
| let { logs, ret } = await runCode(code, language); | |||
| let { logs, ret } = await runCode(code, language, chat); | |||
There was a problem hiding this comment.
Since you pass code, language, and chat to the runCode.
We want to re-render handleRunBrowser with the latest value of chat. It re-renders on change of dependencies.
Therefore, you have a missing dependency: chat on line 114.
It should look like:
}, [onPrompt, code, language, chat]);
vs.
}, [onPrompt, code, language]);
There was a problem hiding this comment.
Currently, it doesn't work as expected, but it works with the oldest value of chat. As you can see messageids aren't updating for the new chats, since chat value isn't updating:
Fixed locally, now the same query returns current data table, since runCode receives updated chat value:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #818, adding a new
<ChatProvider />context and associateduseChat()hook. We can use this to access the currentchatanywhere in the React tree without props.After this lands, it would be nice to refactor our code to not bother passing the chat via props all the time.
You can test this by trying to have the LLM write SQL that references one of the files or tables in DuckDB (e.g.,
select * from chatcraft.chats) and then clicking the run button to execute it.