Moving mass fraction and composition #2144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2144 +/- ##
==========================================
+ Coverage 61.66% 61.81% +0.15%
==========================================
Files 77 78 +1
Lines 8697 8758 +61
==========================================
+ Hits 5363 5414 +51
- Misses 3334 3344 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hey @code-explorer ! Can you rebase this PR? I feel like after that we can get it merged. |
|
@wkerzendorf do we want to use this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🚀
restructureMoving composition and IsotopeAbundance to new composition sub-package and refactoring IsotopeAbundance into IsotopeMassFraction