Restructure/transport solver #2476
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
- Coverage 68.62% 68.46% -0.16%
==========================================
Files 159 159
Lines 13897 13719 -178
==========================================
- Hits 9537 9393 -144
+ Misses 4360 4326 -34 ☔ View full report in Codecov by Sentry. |
| self.use_gpu = use_gpu | ||
|
|
||
| self.virt_logging = virtual_packet_logging | ||
| self.virt_logging = enable_virtual_packet_logging | ||
| self.virt_packet_last_interaction_type = np.ones(2) * -1 |
| self.transport_state = MonteCarloTransportState( | ||
| self.packet_collection, | ||
| estimators, | ||
| simulation_state.volume.cgs.copy(), |
There was a problem hiding this comment.
geometry state and volume duplicate - fix I think in the next one.
There was a problem hiding this comment.
it is fixed in the next one
|
*beep* *bop* Hi, human. The Click here to see your results. |
tardis/grid/tests/test_grid.py
Outdated
| @@ -4,8 +4,11 @@ | |||
| import pandas as pd | |||
|
|
|||
| import tardis | |||
|
|
|||
| from pathlib import Path | |||
There was a problem hiding this comment.
Looks like this is being double imported - check line 1
tardis/io/model_reader.py
Outdated
There was a problem hiding this comment.
On line 675 - I think part of this restructure is trying to make sure we use more informative names. transport_from_hdf mostly operates on a dictionary called d, but it might be worth changing this to a more descriptive name. Not sure if this is outside the scope of this restructure though.
tardis/model/parse_input.py
Outdated
| @@ -5,6 +5,7 @@ | |||
| import pandas as pd | |||
| from astropy import units as u | |||
|
|
|||
| from tardis import constants as const | |||
There was a problem hiding this comment.
Double import here. Also imported immediately below in line 9
tardis/montecarlo/base.py
Outdated
| @@ -31,29 +28,19 @@ | |||
|
|
|||
|
|
|||
| # TODO: refactor this into more parts | |||
| class MontecarloTransport(HDFWriterMixin): | |||
| class MontecarloTransportSolver(HDFWriterMixin): | |||
There was a problem hiding this comment.
Should the C be capitalized for correct camel case?
Checks if the temperature is a quantity or not before trying .value
This is merged next.