Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix units for virtual packet properties in MonteCarloTransportState #2541

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

sarthak-dv
Copy link
Contributor

@sarthak-dv sarthak-dv commented Mar 10, 2024

📝 Description

Type: 🪲 bugfix

Fixed the units in properties for virtual packets in MonteCarloTransportState.

Resolves #2540

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Mar 10, 2024

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@sarthak-dv
Copy link
Contributor Author

@wkerzendorf @andrewfullard Please check this change, as this seems an fundamental one

@andrewfullard
Copy link
Contributor

Thank you for this fix! Looks like some copy-paste got us here. Your changes are correct, I think.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (f515d16) to head (7b18b38).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2541   +/-   ##
=======================================
  Coverage   68.73%   68.73%           
=======================================
  Files         165      165           
  Lines       14001    14001           
=======================================
  Hits         9624     9624           
  Misses       4377     4377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlexHls AlexHls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only formatting needs to be fixed.

@andrewfullard
Copy link
Contributor

Yes please run black on your changes

@sarthak-dv sarthak-dv force-pushed the fix-vpacket-properties branch from 5cd9c87 to 6e24e27 Compare March 12, 2024 00:39
@sarthak-dv
Copy link
Contributor Author

@andrewfullard
I've run the black formatter, please check

@andrewfullard andrewfullard merged commit 07a3083 into tardis-sn:master Mar 12, 2024
12 checks passed
@sarthak-dv sarthak-dv deleted the fix-vpacket-properties branch March 12, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong units for vpacket properties in MonteCarloTransportState
4 participants