-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix units for virtual packet properties in MonteCarloTransportState #2541
Fix units for virtual packet properties in MonteCarloTransportState #2541
Conversation
*beep* *bop* Hi, human. The Click here to see your results. |
@wkerzendorf @andrewfullard Please check this change, as this seems an fundamental one |
Thank you for this fix! Looks like some copy-paste got us here. Your changes are correct, I think. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2541 +/- ##
=======================================
Coverage 68.73% 68.73%
=======================================
Files 165 165
Lines 14001 14001
=======================================
Hits 9624 9624
Misses 4377 4377 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Only formatting needs to be fixed.
Yes please run black on your changes |
5cd9c87
to
6e24e27
Compare
@andrewfullard |
📝 Description
Type: 🪲
bugfix
Fixed the units in properties for virtual packets in MonteCarloTransportState.
Resolves #2540
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label