[GSOC] Benchmarking and Performance Improvement: objective 1 #2547
Conversation
|
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
|
Please provide graphical output and how you achieved the output |
Done |
atharva-2001
requested review from
andrewfullard,
atharva-2001,
aoifeboyle and
AlexHls
and removed request for
aoifeboyle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2547 +/- ##
=======================================
Coverage 68.17% 68.17%
=======================================
Files 166 166
Lines 14135 14135
=======================================
Hits 9636 9636
Misses 4499 4499 ☔ View full report in Codecov by Sentry. |
|
Thanks for the images! Please refer to this pull request in your application. |
|
What command did you run to produce the asv web output? How long did it take to run the benchmark? Why did you choose the number of commits that are shown in the plot? |
|
Are you applying for the shorter or larger project? If the larger, please produce the memory profile as requested. That can be a separate PR. |
first collected hash of last ten commits, then implemented this commands
10-15 mins
I have benchmarked last ten commits. since they depends on the speed of libraries Matplotlib and Plotly, I concentrated on comparing both the methods.
I am mainly interested in the topic benchmarking. And Yes, I will produce another PR on memory profiler, thank you! |
…ithub.com/haleelsada/tardis into benchmark_and_perfomence_improvement_obj1
benchmarks/benchmark_run_tardis.py
Outdated
| params = ['branch85_w7', 'uniform','power_law','exponential'] | ||
| param_names = ['Density'] | ||
|
|
||
| def setup(self, d): |
There was a problem hiding this comment.
d is not a good variable name, please use something more descriptive
| config.model.structure.velocity.stop = 2000 * u.km/u.s | ||
| config.model.structure.velocity.num = 20 | ||
| if d == 'uniform': | ||
| config.model.structure.density.time_0 = 1 * u.day |
There was a problem hiding this comment.
If many of these settings are the same, they don't need to be in the if statements
There was a problem hiding this comment.
I have added the common settings outside the if clause and anything that differ from default inside the if clause. I thought it would be better for readability.
Parameter is changed from d to density for better readability in benchmark_run_tardis.
📝 Description
Type: :🌞
GSoC| 🚀featurePR on first objective of idea
TARDIS Benchmarking and Performance ImprovementGSOC'24.Added 2 benchmarks for SDEC plotter using Matplotlib and Plotly. Observed Plotly is much faster than Matplotlib.
Implemented by first running run_tardis then benchmarking the SDEC plotting using libraries Plotly(generate_plot_ply) and Matplotlib(generate_plot_mpl) on the output of run_tardis.
📌 Resources
Tardis Ideas
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel