Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken import modules in main gamma ray loop. #2591

Closed
wants to merge 7 commits into from
Closed

Fixed the broken import modules in main gamma ray loop. #2591

wants to merge 7 commits into from

Conversation

airvzxf
Copy link
Contributor

@airvzxf airvzxf commented Apr 20, 2024

📝 Description

Type: 🪲 bugfix.

Bug fix: Broken modules imported for Gamma Ray. #2590.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

N/A

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)
    • There is no unit test for run_gamma_ray_loop.
    • This function is used in docs/working_gamma_ray_test.ipynb.

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@airvzxf airvzxf marked this pull request as draft April 20, 2024 05:24
@airvzxf
Copy link
Contributor Author

airvzxf commented Apr 20, 2024

Generating the docs, it throws the below errors. I'll fix them.

/app/code/tardis/energy_input/gamma_ray_channel.py:docstring of tardis.energy_input.gamma_ray_channel.create_isotope_dicts:19:
- ERROR: Unexpected indentation.

/app/code/tardis/energy_input/gamma_ray_transport.py:docstring of tardis.energy_input.gamma_ray_transport.fractional_decay_energy:6:
- ERROR: Unexpected indentation.

/app/code/tardis/energy_input/gamma_ray_transport.py:docstring of tardis.energy_input.gamma_ray_transport:3:
- WARNING: Block quote ends without a blank line; unexpected unindent.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@airvzxf
Copy link
Contributor Author

airvzxf commented Apr 20, 2024

The commit: 20ed081, fixes the errors when building the documents with the command cd docs; DISABLE_NBSPHINX=1 make html NCORES=auto.

@airvzxf
Copy link
Contributor Author

airvzxf commented Apr 20, 2024

The commit: 9b09bce, fix a possible typo for the curly braces.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@airvzxf
Copy link
Contributor Author

airvzxf commented Apr 20, 2024

The commit: fff66e1, align the format for all the functions in gamma_ray_channel.py.

@airvzxf airvzxf marked this pull request as ready for review April 20, 2024 07:33
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run black on main_gamma_ray_loop.py

@airvzxf
Copy link
Contributor Author

airvzxf commented Apr 22, 2024

Please run black on main_gamma_ray_loop.py

Done in the commit: abe3b0d.

1st UPDATE:
I committed these changes in the other branch, let me do in this branch.

2nd UPDATE:
Done in the commit: 32fbcf4. The GitHub workflow action passed.

https://github.com/tardis-sn/tardis/actions/runs/8787624433/job/24113261782?pr=2591

Run black --check tardis
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install black[jupyter]``
All done! ✨ 🍰 ✨
229 files would be left unchanged.

@andrewfullard
Copy link
Contributor

This should have been resolved with #2546 , please rebase and check.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@airvzxf
Copy link
Contributor Author

airvzxf commented Apr 25, 2024

This should have been resolved with #2546 , please rebase and check.

Sorry, doing rebase is difficult for me, after some years, I still not understand a lot, my brain got confuse. I need a deep course for rebase newbies.

Done in commit: 95a5925.

@andrewfullard
Copy link
Contributor

Okay, looks like the only changes here are whitespace so I'm going to close this PR.

@airvzxf airvzxf deleted the bugfix/broken-imports-gamma-ray branch April 25, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants