-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the broken import modules in main gamma ray loop. #2591
Conversation
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
Generating the docs, it throws the below errors. I'll fix them.
|
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
The commit: 20ed081, fixes the errors when building the documents with the command |
The commit: 9b09bce, fix a possible typo for the curly braces. |
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
The commit: fff66e1, align the format for all the functions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run black
on main_gamma_ray_loop.py
1st UPDATE: 2nd UPDATE: https://github.com/tardis-sn/tardis/actions/runs/8787624433/job/24113261782?pr=2591
|
This should have been resolved with #2546 , please rebase and check. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Okay, looks like the only changes here are whitespace so I'm going to close this PR. |
📝 Description
Type: 🪲
bugfix
.Bug fix: Broken modules imported for Gamma Ray. #2590.
Also, link issues affected by this pull request by using the keywords:
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
orresolved
.fix
andclose
.📌 Resources
Examples, notebooks, and links to useful references.
N/A
🚦 Testing
How did you test these changes?
run_gamma_ray_loop
.docs/working_gamma_ray_test.ipynb
.☑️ Checklist
build_docs
label