Release Fixes #2886
Merged
Release Fixes #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharva-2001
force-pushed
the
release_fixes4
branch
from
b18fe20 to
5fbe48b
Compare
|
*beep* *bop* 7 W293 [*] Blank line contains whitespace
1 E999 [ ] SyntaxError: Expected an expression
1 W292 [*] No newline at end of file
Complete output(might be large): .github/workflows/release.yml:7:4: E999 SyntaxError: Expected an expression
.github/workflows/release.yml:93:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:96:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:103:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:106:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:109:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:114:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:118:1: W293 [*] Blank line contains whitespace
.github/workflows/release.yml:142:23: W292 [*] No newline at end of file
Found 9 errors.
[*] 8 fixable with the `--fix` option.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2886 +/- ##
==========================================
- Coverage 70.24% 69.87% -0.38%
==========================================
Files 214 214
Lines 15981 15981
==========================================
- Hits 11226 11166 -60
- Misses 4755 4815 +60 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
andrewfullard
approved these changes
Nov 20, 2024
|
*beep* *bop* Significantly changed benchmarks: All benchmarks: Benchmarks that have stayed the same:
| Change | Before [20b8120b] <master> | After [50001c5e] | Ratio | Benchmark (Parameter) |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
| | 1.51±0.3μs | 2.62±0.3μs | ~1.74 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line |
| | 2.94±0.3μs | 3.59±0.4μs | ~1.22 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket |
| | 3.16±0.5μs | 3.77±0.5μs | ~1.19 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell |
| | 2.00±2μs | 2.26±1μs | ~1.13 | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators |
| | 541±100ns | 601±100ns | ~1.11 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation |
| | 541±100ns | 471±100ns | ~0.87 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation |
| | 8.00±1μs | 6.85±1μs | ~0.86 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley |
| | 25.4±7μs | 20.3±4μs | ~0.80 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
| | 5.90±0.9μs | 6.42±1μs | 1.09 | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket |
| | 2.74±0.02ms | 2.95±0.02ms | 1.08 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter') |
| | 601±100ns | 632±200ns | 1.05 | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation |
| | 2.54±0.4ms | 2.63±0.4ms | 1.04 | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop |
| | 730±0.6ns | 742±0.7ns | 1.02 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter |
| | 1.68±0.1ms | 1.71±0.01ms | 1.02 | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop |
| | 63.7±0.1ms | 64.8±0.6ms | 1.02 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe |
| | 205±0.5ns | 206±0.3ns | 1.01 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body |
| | 1.07±0m | 1.06±0m | 1.00 | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking |
| | 2.07±0m | 2.07±0m | 1.00 | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions |
| | 31.2±0.08μs | 30.8±0.02μs | 0.99 | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list |
| | 40.9±0.09s | 40.2±0.06s | 0.98 | run_tardis.BenchmarkRunTardis.time_run_tardis |
| | 1.20±0μs | 1.18±0μs | 0.98 | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary |
| | 42.5±20μs | 40.0±20μs | 0.94 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission |
| | 3.79±0.01ms | 3.54±0.01ms | 0.93 | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom') |
| | 47.0±30μs | 43.8±30μs | 0.93 | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter |
If you want to see the graph of the results, you can check it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructurejupytercommand works which failed last time-https://github.com/tardis-sn/tardis/actions/runs/11935801832
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel