Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed expected to expected_fh #2949

Closed
wants to merge 3 commits into from
Closed

Changed expected to expected_fh #2949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
106cc91
changed expected to expected_fh
kevinzb56 Jan 14, 2025
f2dacd3
Merge branch 'tardis-sn:master' into master
kevinzb56 Jan 22, 2025
c1a9524
Changed expected to expected_fh
kevinzb56 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tardis/io/configuration/tests/test_config_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,13 @@ def test_from_config_dict(tardis_config_verysimple):


def test_config_hdf(hdf_file_path, tardis_config_verysimple):
expected = Configuration.from_config_dict(
expected_fh = Configuration.from_config_dict(
tardis_config_verysimple, validate=True, config_dirname="test"
)
expected.to_hdf(hdf_file_path, overwrite=True)
expected_fh.to_hdf(hdf_file_path, overwrite=True)
actual = pd.read_hdf(hdf_file_path, key="/simulation/config")
expected = expected.get_properties()["config"]
assert actual[0] == expected[0]
expected_fh = expected_fh.get_properties()["config"]
assert actual[0] == expected_fh[0]


def test_model_section_config(tardis_config_verysimple):
Expand Down
6 changes: 3 additions & 3 deletions tardis/visualization/widgets/shell_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def update_element_count_table(self, event, qgrid_widget):
Notes
-----
You will never need to pass any of these arguments explicitly. This is
the expected signature of the function passed to :code:`handler` argument
the expected_fh signature of the function passed to :code:`handler` argument
of :code:`on` method of a table widget (qgrid.QgridWidget object) as
explained in `qrid documentation <https://qgrid.readthedocs.io/en/latest/#qgrid.QgridWidget.on>`_.
"""
Expand Down Expand Up @@ -350,7 +350,7 @@ def update_ion_count_table(self, event, qgrid_widget):
Notes
-----
You will never need to pass any of these arguments explicitly. This is
the expected signature of the function passed to :code:`handler` argument
the expected_fh signature of the function passed to :code:`handler` argument
of :code:`on` method of a table widget (qgrid.QgridWidget object) as
explained in `qrid documentation <https://qgrid.readthedocs.io/en/latest/#qgrid.QgridWidget.on>`_.
"""
Expand Down Expand Up @@ -385,7 +385,7 @@ def update_level_count_table(self, event, qgrid_widget):
Notes
-----
You will never need to pass any of these arguments explicitly. This is
the expected signature of the function passed to :code:`handler` argument
the expected_fh signature of the function passed to :code:`handler` argument
of :code:`on` method of a table widget (qgrid.QgridWidget object) as
explained in `qrid documentation <https://qgrid.readthedocs.io/en/latest/#qgrid.QgridWidget.on>`_.
"""
Expand Down
Loading