Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liv plot notebook to the analyzing tardis outputs section #2985

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

KasukabeDefenceForce
Copy link
Contributor

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Add a notebook for liv plot

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@KasukabeDefenceForce KasukabeDefenceForce changed the title Liv notebook Add liv plot notebook to the analyzing tardis outputs section Feb 21, 2025
@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran ruff on the latest commit (7022e3a).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

7	W291  	[*] Trailing whitespace
6	W293  	[*] Blank line contains whitespace
4	E999  	[ ] SyntaxError: Expected a statement
2	RET506	[ ] Unnecessary `else` after `raise` statement

Complete output(might be large):

docs/analysing_tardis_outputs/index.rst:1:1: E999 SyntaxError: Expected an expression
docs/analysing_tardis_outputs/index.rst:12:1: W293 [*] Blank line contains whitespace
docs/analysing_tardis_outputs/spectrum/index.rst:1:1: E999 SyntaxError: Expected a statement
docs/analysing_tardis_outputs/spectrum/index.rst:7:1: W293 [*] Blank line contains whitespace
docs/analysing_tardis_outputs/spectrum/sdec_notebook.ipynb:cell 20:6:67: W291 [*] Trailing whitespace
docs/analysing_tardis_outputs/visualization/index.rst:1:1: E999 SyntaxError: Expected a statement
docs/analysing_tardis_outputs/visualization/index.rst:25:1: W293 [*] Blank line contains whitespace
docs/index.rst:1:1: E999 SyntaxError: Expected a statement
docs/index.rst:21:51: W291 [*] Trailing whitespace
docs/index.rst:43:76: W291 [*] Trailing whitespace
docs/index.rst:44:64: W291 [*] Trailing whitespace
docs/index.rst:45:71: W291 [*] Trailing whitespace
docs/index.rst:46:69: W291 [*] Trailing whitespace
docs/index.rst:47:68: W291 [*] Trailing whitespace
docs/index.rst:66:1: W293 [*] Blank line contains whitespace
docs/index.rst:88:1: W293 [*] Blank line contains whitespace
docs/index.rst:112:1: W293 [*] Blank line contains whitespace
tardis/visualization/sdec/util.py:115:9: RET506 Unnecessary `else` after `raise` statement
tardis/visualization/sdec/util.py:273:9: RET506 Unnecessary `else` after `raise` statement
Found 19 errors.
[*] 13 fixable with the `--fix` option.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 96 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (cec8b53) to head (7022e3a).

Files with missing lines Patch % Lines
tardis/visualization/sdec/util.py 0.00% 96 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
- Coverage   69.52%   68.76%   -0.76%     
==========================================
  Files         228      229       +1     
  Lines       16429    16525      +96     
==========================================
- Hits        11422    11364      -58     
- Misses       5007     5161     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants