chore: remove use of default for points and scalars #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any other changes needed to merge? |
|
Is anything blocking a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the
Defaultimplementation for Ristretto point and scalar types is somewhat non-idiomatic, since it isn't immediately clear what a "default" point or scalar must be. In practice, these are the identity group element and zero scalar, respectively.This PR removes ambiguity and makes the library more future proof by removing all such uses. Instead, it uses the
Identityimplementation for point types and theZEROconstant for scalars.Closes #141.