Skip to content

Commit

Permalink
feat(p2pool): fixed share chain synchronization and applied strongest…
Browse files Browse the repository at this point in the history
… chain consensus rules (#19)

Description
---
Synchronization was unstable and random, so I fixed it by applying the
longest (strongest) chain consensus rules on share chain blocks and
fixed logic when and what to sinchronize.

Motivation and Context
---

How Has This Been Tested?
---
Firstly I ran locally 2 separate p2pool nodes with 2 separate miners on
2 different wallet addresses.
Then disabled mDNS on both of the nodes and used a test node as
bootstrap node for both of them and run mining again.
Lastly I tested with @therealdannzor with the same test node as
bootstrap.

All the cases were working fine and I was able to mine blocks together
with pool members.

What process can a PR reviewer use to test or verify this change?
---
Start 2 p2pool nodes locally and start 2 miners on both of them and see
the new mined rewards coming after some time.


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify
  • Loading branch information
ksrichard authored Jul 12, 2024
1 parent 81139b6 commit 787d2be
Show file tree
Hide file tree
Showing 15 changed files with 607 additions and 633 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,6 @@ jobs:
matrix:
tari_target_network: [
{ target: "testnet", network: "esmeralda" },
{ target: "nextnet", network: "nextnet" },
{ target: "mainnet", network: "stagenet" },
]
env:
TARI_TARGET_NETWORK: ${{ matrix.tari_target_network.target }}
Expand Down
Loading

0 comments on commit 787d2be

Please sign in to comment.