-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): global substates in dedicated shard #1269
Merged
sdbondi
merged 19 commits into
tari-project:development
from
ksrichard:feature/global-substates-in-dedicated-shard
Feb 7, 2025
Merged
feat(consensus): global substates in dedicated shard #1269
sdbondi
merged 19 commits into
tari-project:development
from
ksrichard:feature/global-substates-in-dedicated-shard
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-substates-in-dedicated-shard # Conflicts: # applications/tari_validator_node/src/bootstrap.rs
Test Results (CI)619 tests +25 610 ✅ +16 3h 36m 19s ⏱️ + 2h 3m 17s For more details on these failures, see this check. Results for commit 794c646. ± Comparison against base commit ddc4632. ♻️ This comment has been updated with latest results. |
…-shard * development: fix(consensus)!: remove substate value when substate is DOWN (tari-project#1274) feat(consensus): skip to local accept phase for aborted transactions (tari-project#1273) chore: update package.json for wallet client (tari-project#1272) chore: update package.json for wallet client (tari-project#1271) feat!: accumulate leader fees in substate, impl claim fees in wallet (tari-project#1270)
cff9c40
to
12a5487
Compare
sdbondi
previously approved these changes
Feb 6, 2025
sdbondi
previously approved these changes
Feb 6, 2025
fb943fd
to
a062dea
Compare
sdbondi
previously approved these changes
Feb 7, 2025
sdbondi
previously approved these changes
Feb 7, 2025
sdbondi
previously approved these changes
Feb 7, 2025
sdbondi
approved these changes
Feb 7, 2025
Merged
via the queue into
tari-project:development
with commit Feb 7, 2025
6e1e4e5
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We reserve a specific shard (
0
) for all the global substates, so regardless of which shard it would be in calculated from it's address, we use the hardcoded shard.Motivation and Context
When a node loses all of its data or behind a lot the tip of chain, then it synchronizes the chain, but in this case we do not have the templates all the time as a substates as it is not guaranteed that templates shard is falling into the shard group's range (where the actual VN is).
How Has This Been Tested?
Scenarios
New VN added to swarm
Using CLI (example):
Add VN
on swarm UI (http://127.0.0.1:8080/)VN gets out of sync / loose data
Using CLI (example):
0-X
shard group and make sure the template presents as well on the VNDelete Data
button at the VN (it will stop the VN as well)What process can a PR reviewer use to test or verify this change?
Breaking Changes