Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: accumulate leader fees in substate, impl claim fees in wallet #1270

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 29, 2025

Description

Accumulate leader fees in ValidatorFeePool substate as blocks are proposed
Implement fee claim transactions in wallet daemon
Update bindings
Implement claim fee in wallet web UI
Implement fee scanning in wallet for a given key
Swarm uses key 0 of the wallet daemon as claim key for all validators

Motivation and Context

For non-zero block fees, a round leader must include a (Down->)Up transition in the state Merkle tree for their ValidatorFeePool substate (as defined by their claim public key).

How Has This Been Tested?

New (unignored) cucumber tests, manually

What process can a PR reviewer use to test or verify this change?

Claim fee feature in wallet web UI

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Jan 29, 2025

Test Results (CI)

594 tests   - 19   594 ✅  - 18   1h 27m 24s ⏱️ - 2h 23m 53s
 55 suites  - 12     0 💤 ± 0 
  1 files    -  1     0 ❌  -  1 

Results for commit 3c12ca4. ± Comparison against base commit 39d36ec.

This pull request removes 25 and adds 6 tests. Note that renamed tests count towards both.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:83:3
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:9:3
Scenario: Concurrent calls to the Counter template: tests/features/concurrency.feature:7:3
Scenario: Confidential transfer to account that does not previously exist: tests/features/transfer.feature:151:3
Scenario: Counter template registration and invocation multiple times: tests/features/counter.feature:46:3
Scenario: Counter template registration and invocation once: tests/features/counter.feature:8:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:8:3
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:125:3
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:80:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:48:3
…
tari_dan_common_types ‑ shard_group::tests::to_string_and_parsing
tari_engine_types ‑ vn_fee_pool::export_bindings_validatorfeepool
tari_engine_types ‑ vn_fee_pool::export_bindings_validatorfeepooladdress
tari_wallet_daemon_client ‑ component_address::export_bindings_componentaddressorname
tari_wallet_daemon_client ‑ types::export_bindings_accountorkeyindex
tari_wallet_daemon_client ‑ types::export_bindings_feepooldetails

♻️ This comment has been updated with latest results.

@sdbondi
Copy link
Member Author

sdbondi commented Jan 29, 2025

Due to bindings release 1.4.0 cargo check and cucumber build fails

@sdbondi sdbondi merged commit 7f02e2c into tari-project:development Jan 29, 2025
10 of 12 checks passed
sdbondi added a commit to sdbondi/tari-dan that referenced this pull request Feb 5, 2025
…-shard

* development:
  fix(consensus)!: remove substate value when substate is DOWN (tari-project#1274)
  feat(consensus): skip to local accept phase for aborted transactions (tari-project#1273)
  chore: update package.json for wallet client (tari-project#1272)
  chore: update package.json for wallet client (tari-project#1271)
  feat!: accumulate leader fees in substate, impl claim fees in wallet (tari-project#1270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants