feat(consensus): skip to local accept phase for aborted transactions #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-optimise-abort-case
branch
from
f008604 to
4a2851c
Compare
sdbondi
force-pushed
the
consensus-optimise-abort-case
branch
from
4a2851c to
a30267b
Compare
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 5, 2025
…-shard * development: fix(consensus)!: remove substate value when substate is DOWN (tari-project#1274) feat(consensus): skip to local accept phase for aborted transactions (tari-project#1273) chore: update package.json for wallet client (tari-project#1272) chore: update package.json for wallet client (tari-project#1271) feat!: accumulate leader fees in substate, impl claim fees in wallet (tari-project#1270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(consensus): skip to local accept phase for aborted transactions
Missing consensus-level transaction validators
Additional atom checks in LocalAccept
Motivation and Context
Since aborted transactions do not lock or pledge inputs, they can proceed directly to Accept phase
This removes the need for 2 cross-shard exchanges.
How Has This Been Tested?
Still testing
What process can a PR reviewer use to test or verify this change?
Breaking Changes