feat: foreign proposal transaction timeout #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cifko
force-pushed
the
timeout
branch
3 times, most recently
from
f0fc700 to
7612699
Compare
Cifko
force-pushed
the
timeout
branch
3 times, most recently
from
2dce482 to
1e50f4e
Compare
stringhandler
previously approved these changes
Jan 26, 2024
sdbondi
reviewed
Jan 29, 2024
| @@ -74,6 +74,7 @@ message ForeignProposal { | |||
| bytes block_id = 2; | |||
| ForeignProposalState state = 3; | |||
| uint64 mined_at = 4; | |||
There was a problem hiding this comment.
Suggest proposed_height. This has already changed in development but I missed this in the proto file
dan_layer/state_store_sqlite/migrations/2023-06-08-091819_create_state_store/up.sql
Outdated
Show resolved
Hide resolved
sdbondi
approved these changes
Feb 5, 2024
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Feb 5, 2024
* development: feat: foreign proposal transaction timeout (tari-project#802) fix: use hash domains from tari_hash_domains (tari-project#925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transaction (from foreign proposals) timeout.
For every Foreign proposal we store new column with all the transactions id. Once we receive local block where the transaction should be resolved and it's not (it's not finalized, or the current state is not at least LocalPrepared) we update the local decision to abort.
Motivation and Context
How Has This Been Tested?
N/A
What process can a PR reviewer use to test or verify this change?
Breaking Changes