fix!: use configured network string in networking protocol #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
Merged
via the queue into
tari-project:development
with commit Jan 11, 2024
b7ccff2
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use string from
Network::as_strin the protocol identifierMotivation and Context
This change uses the configured network in the
/tari/{network}/{version}protocol string. This string is used to identify different networks. If peers are on a different network (by libp2p identify) the peers disconnect.How Has This Been Tested?
Partially manually by checking that the protocol string is set per the network. Cucumbers also partially test this case.
What process can a PR reviewer use to test or verify this change?
Try connect two VNs, one with
--network localnetand the other with--network igorBreaking Changes