Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account parser in claim fee request #876

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Jan 4, 2024

Description

Allow the account to be parsed from string

Motivation and Context

Upon some testing I came to this issue.

How Has This Been Tested?

In my testing environment I'm doing claiming fees, and I was able to claim them successfuly.

What process can a PR reviewer use to test or verify this change?

You can try to call the jrpc with string and you will see an error without this change.

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

github-actions bot commented Jan 4, 2024

Test Results (CI)

72 tests   - 121   70 ✅  - 122   43m 49s ⏱️ - 30m 57s
16 suites  -  36    0 💤 ±  0 
 1 files    -   1    2 ❌ +  1 

For more details on these failures, see this check.

Results for commit bbca0da. ± Comparison against base commit 516c5d1.

This pull request removes 121 tests.
Scenario: Claim and transfer confidential assets via wallet daemon: tests/features/wallet_daemon.feature:89:5
Scenario: Claim base layer burn funds with wallet daemon: tests/features/claim_burn.feature:6:3
Scenario: Claim validator fees: tests/features/claim_fees.feature:6:3
Scenario: Confidential transfer to unexisting account: tests/features/transfer.feature:163:3
Scenario: Counter template registration and invocation: tests/features/counter.feature:7:3
Scenario: Create account and transfer faucets via wallet daemon: tests/features/wallet_daemon.feature:7:5
Scenario: Create and mint account NFT: tests/features/wallet_daemon.feature:133:5
Scenario: Create resource and mint in one transaction: tests/features/nft.feature:73:3
Scenario: Double Claim base layer burn funds with wallet daemon. should fail: tests/features/claim_burn.feature:44:3
Scenario: Indexer GraphQL requests events over network substate indexing: tests/features/indexer.feature:118:3
…

@sdbondi sdbondi added this pull request to the merge queue Jan 5, 2024
Merged via the queue into tari-project:development with commit 6d30028 Jan 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants