fix(consensus): dont send dummy blocks on sync #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-sync-no-dummy-blocks
branch
from
e0d0daa to
ac444e2
Compare
sdbondi
force-pushed
the
consensus-sync-no-dummy-blocks
branch
from
ac444e2 to
5f84061
Compare
sdbondi
force-pushed
the
consensus-sync-no-dummy-blocks
branch
from
5f84061 to
659a71c
Compare
sdbondi
changed the title
sdbondi
force-pushed
the
consensus-sync-no-dummy-blocks
branch
from
659a71c to
673b5ae
Compare
Merged
via the queue into
tari-project:development
with commit Jan 16, 2024
347846f
10 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Excludes dummy blocks from catch-up sync
Excludes dummy blocks from RPC sync
Rename
tari_comms_rpc_state_synctotari_rpc_state_syncRemoved commented-out and dead code
Motivation and Context
The is_dummy flag is not sent on catch-up, which leads to a "missing proposal signature" error, since summy blocks cannot be signed. Dummy blocks are calculated as needed by the proposal handler so do not need to be sent.
When testing manually this works, however, we sometimes run into #887
How Has This Been Tested?
Manually, synced chain with dummy blocks and checked that dummy blocks created
What process can a PR reviewer use to test or verify this change?
4 VN committee, shut down one node and delete its data, wait for leader failures (to create some dummy blocks), restart node, and check that it syncs
Breaking Changes